Repository navigation
Migrate Spring AI samples to standalone package and Spring AI 2 - #810
brianstrauch wants to merge 2 commits into
Conversation
patbeqo
left a comment
There was a problem hiding this comment.
Can we add an MCP test like the basic and multimodel ones? A fake McpClientActivity that returns one tool would have caught the defaultTools issue below.
DABH
left a comment
There was a problem hiding this comment.
Reviewed 409a90a. No new correctness regressions found in the migration; the previously reported callback-registration and RAG retry issues are fixed.
Validated on Java 17: repository-wide spotlessCheck, builds of all four Spring AI modules, and all three credential-free regression tests. Additional probes verified the actual multimodel thinking route and history replay, and a real Spring Boot RAG context against a local HTTP 500 endpoint: chat and embedding now each make one HTTP request per call, versus four embedding requests before the fix.
A full Spring Boot/stdio MCP probe also exposed an inherited client-discovery defect on both base and this head; I added a non-blocking inline follow-up with the reproduction and a passing control. The fake-activity regression test correctly covers the callback fix, but does not exercise that existing wiring issue.
One CI Unit Tests job currently fails in the unchanged HelloWorkflowTimerTest. The other Unit Tests job passed, and the focused timer test also passed locally; this PR does not change core sources or their build configuration.
Migrate the basic, MCP, multi-model, and RAG samples to the independently versioned
io.temporal:spring-ai:0.1.1package with Spring AI 2.0.1 and Spring Boot 4.0.8.defaultTools, using the callback pass-through fix released in Temporal Spring AI 0.1.1.spring.ai.openai.max-retries: 0for both chat and embedding models.McpClientActivitythat advertises one tool and verifies its arguments and result.Validated on Java 21 with repository-wide
spotlessCheckand builds of all four Spring AI modules:All three regression tests pass without provider credentials or external services. The new MCP test reproduces the
No @Tool annotated methods foundfailure with Temporal Spring AI 0.1.0 and passes with 0.1.1.