Repository navigation
Fix Elasticsearch health check URL quoting - #160
Merged
Merged
Conversation
S15
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Quote the URL so Compose waits for a successful Elasticsearch response before starting dependent services.
Why?
The shell interpreted the unquoted & in the Elasticsearch health check URL as a background operator. It ran curl asynchronously and treated timeout=1s as a successful variable assignment, causing the health check to pass before Elasticsearch was ready.
With this fix, dependent services actually wait for Elasticsearch to finish starting, preventing
temporal-admin-toolsfrom exhausting its retries prematurely.Go SDK has been seeing a bunch of failures for the docker job, https://github.com/temporalio/sdk-go/actions/runs/37641169691?pr=2733
Checklist
Closes
How was this tested: