Skip to content

Fix Elasticsearch health check URL quoting - #160

Merged
yuandrew merged 1 commit into
mainfrom
yuandrew/fix-search-healthcheck
Oct 7, 2026
Merged

yuandrew merged 1 commit into
mainfrom
yuandrew/fix-search-healthcheck

Conversation

@yuandrew

@yuandrew yuandrew commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Quote the URL so Compose waits for a successful Elasticsearch response before starting dependent services.

Why?

The shell interpreted the unquoted & in the Elasticsearch health check URL as a background operator. It ran curl asynchronously and treated timeout=1s as a successful variable assignment, causing the health check to pass before Elasticsearch was ready.

With this fix, dependent services actually wait for Elasticsearch to finish starting, preventing temporal-admin-tools from exhausting its retries prematurely.

Go SDK has been seeing a bunch of failures for the docker job, https://github.com/temporalio/sdk-go/actions/runs/37641169691?pr=2733

Checklist

  1. Closes

  2. How was this tested:

  • Confirmed the original health check returns success against a closed port because the shell treats & as a background operator.
  • Confirmed the quoted URL returns a failure against a closed port.
  • Validated all modified files with docker compose config.
  • Started the full PostgreSQL, Elasticsearch, admin-tools, and Temporal stack. Elasticsearch and Temporal became healthy, and admin-tools completed successfully without connection-refused errors.
  1. Any docs updates needed?

@yuandrew
yuandrew requested a review from a team as a code owner October 7, 2026 17:11
@yuandrew
yuandrew merged commit dd5a3b5 into main Oct 7, 2026
13 checks passed
@yuandrew
yuandrew deleted the yuandrew/fix-search-healthcheck branch October 7, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants