Support Standalone Activity client in temporal-testing#2916
Open
444am wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added ActivityClient support to temporal-testing, and updated README.
ℹ️ I understand that with this change, Standalone Activity would be still yet properly supported in local Test Server. However as the changes to that part would be mostly in
temporal-test-server, I would like to keep this PR focusing onTestWorkflowEnvironmentcontract enrichment.Why?
Standalone Activity tests had to manually construct an ActivityClient from service stubs and options. This PR makes standalone activity testing use the same test-environment API style as Workflow Client testing.
How was this tested:
See the new UT file