Repository navigation
Conversation
…emporalio#2008) Signed-off-by: musi22 <shawrashmi7@gmail.com>
|
|
Contributor
|
There's already an open PR for this issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Populate
equest_id=str(uuid.uuid4())\ when constructing \TerminateActivityExecutionRequest\ in _ClientImpl.terminate_activity().
Why?
\ erminate_activity\ calls \ erminate_activity_execution\ with
etry=True. When
equest_id\ was omitted, the server generated a new request ID on every retry attempt, meaning retried RPCs could not be deduplicated if the initial response was dropped (e.g. transient network glitch). The retried request then failed with \NotFound: no running activity execution: it closed with status TERMINATED.
Setting
equest_id\ makes retries idempotent, matching sibling calls (\cancel_activity, \pause_activity, \unpause_activity, \start_activity) and the Temporal Go SDK.
Testing
Added unit test in \ ests/test_activity_operator_commands_requests.py\ verifying that \TerminateActivityExecutionRequest\ sent over the wire contains a valid non-empty UUID
equest_id.
Fixes #2008