feat: allow RollingUpdate to be specified for k8s Deployment - #497
Open
otan wants to merge 7 commits into
Open
Conversation
otan
force-pushed
the
feat/deployment-rolling-update-strategy
branch
from
August 3, 2026 19:42
a728390 to
baf447c
Compare
|
|
otan
force-pushed
the
feat/deployment-rolling-update-strategy
branch
from
August 3, 2026 19:42
baf447c to
f171c37
Compare
Expose maxUnavailable/maxSurge on owned version Deployments for less disruptive in-place restarts. Co-authored-by: Cursor <cursoragent@cursor.com>
otan
force-pushed
the
feat/deployment-rolling-update-strategy
branch
from
August 3, 2026 19:43
f171c37 to
e880e0e
Compare
Collaborator
|
@otan thanks so much for this contribution! I'll review a little later today or tomorrow morning. Been looking into some bug fixes earlier this week. |
jaypipes
requested changes
Aug 6, 2026
…ng-update-strategy
…ozen Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
all good! |
eniko-dif
reviewed
Aug 7, 2026
…ng-update-strategy
otan
force-pushed
the
feat/deployment-rolling-update-strategy
branch
from
August 7, 2026 20:19
9f11f30 to
7b3824e
Compare
Author
|
all done |
Deep-copy strategy defaults so comparison does not mutate live Deployments, and move CR defaulting/validation onto the WorkerDeployment webhook.
otan
force-pushed
the
feat/deployment-rolling-update-strategy
branch
from
August 7, 2026 20:19
7b3824e to
8672c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
spec.strategyfield onWorkerDeployment(and the deprecatedTemporalWorkerDeployment) that mirrorsapps/v1Deployment.spec.strategy. The controller applies it to owned versioned Deployments on create/update and reconciles drift so settings likemaxUnavailable/maxSurgestick.This is distinct from
spec.rollout.strategy, which controls Temporal traffic routing across versions.Why
Owned Deployments currently inherit the Kubernetes default rolling update (
25%/25%). On large fleets, in-place restarts of a Current version (same build ID) can take too many pollers offline at once and spikeschedule_to_start. Users need a conservative strategy such asmaxUnavailable: 5%.Testing
make generate manifestsgo test ./internal/k8s/ ./internal/planner/ -run 'Strategy|ApplyDeploymentStrategyDefaults|ReplicasNilPreserved'Resolves #496