Repository navigation
fix(cards): pre-reader tiles lock a recurring chore in its cooldown - #1188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cards): pre-reader tiles lock a recurring chore in its cooldown
With pre_reader: true, a recurring chore waiting to reset stayed a live tile:
the tile checked a flag nothing ever set, so a tap went through. The same
was true of a sibling's first-come claim, a filled weekly target, a missed
time window, a chore not due today (due_days_mode: dim) and a set time that
isn't open.
The tile now takes its locks from the same helper as the classic row,
_choreLocks, so it is greyed out and does nothing when tapped in exactly the
cases the standard row refuses. A chore ticked today keeps its undo. The
dead _isAvailableForChild flag is gone, and the wiki no longer lists
pre-reader tiles as ignoring first_come_claimed_mode / recurrence_done_mode.
docs(wiki): pre-reader tiles honour the first-come claimed lock
The first-come section still listed pre-reader tiles as ignoring the lock
after the tile fix; only timed-task cards are left uncovered there.
Testing