Repository navigation
fix(cards): timed chores can't be started while the chore is locked - #1190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cards): timed chores can't be started while the chore is locked
A timed chore only refused Start for a missing prerequisite, so one in its
recurrence cooldown, claimed first by a sibling, for a later part of the
day, past its window, not due today, at its weekly target or at a closed
set time could still be started — on classic and every designed style.
Start and Resume now take their locks from _choreLocks, the same helper
the classic row uses, and look disabled. Pause and Done stay live so a
session already running can always be ended. The wiki no longer lists
timed-task cards as ignoring first_come_claimed_mode.
fix(cards): a locked timed chore is dimmed and says why
Greying Start alone left a locked timed chore looking live, with no reason
given, unlike the standard rows. It now dims the same way under the same
modes (recurrence, first-come and dependency locks only under "dim"), and
names the reason under the chore's name in the standard rows' words —
"Available at 17:00", "Time has passed for this chore", "Do Teeth first",
the recurrence, who claimed it, and so on — in every design. A session
already running or paused stays at full strength so it can be ended.
fix(cards): a locked timed chore's opening time follows HA's clock
"Available at 17:00" and a set time's opening time on a locked timed
chore now go through the shared clock helper when it is loaded, so a
12-hour HA profile reads "05:00 PM" (#771).
fix(cards): a locked timed chore's cooldown reason uses the translated cadence
When the card has the translated recurrence label (fix/recurrence-label-i18n),
the timed card's lock reason uses it too instead of the raw key (#771).
Testing