Repository navigation
fix(cards): give the Routine card a working visual editor - #1217
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the previous PR in this batch (perf/lazy-locales-editors).
fix(cards): give the Routine card a working visual editor
The Routine card had an editor that Home Assistant never opened, so it
could only be set up in YAML. Its fields were also English-only, the
child and time-of-day dropdowns showed raw ids and values, and its
options used a list component current Home Assistant no longer ships.
The card now opens a visual editor like every other TaskMate card: pick
the child by name, the time of day the routine covers (Whole day takes
every chore due today), an optional title, the card design and the
header colour. Every label and helper is translated, the card's defaults
stay out of the YAML, and the YAML editor round-trips.
fix(cards): style the header-colour picker in four card editors
The Heatmap, Personal Bests, Raffle and Wishlist card editors drew the
shared header-colour picker without its styles, so it showed as a plain
colour input, a row of tiny bare buttons and an unstyled Reset button.
It now looks like it does in every other TaskMate card editor: a round
swatch, the hex value, round preset colours and a Reset chip.
Testing