Skip to content

fix(timed): a timer reaching its cap no longer breaks the refresh, and a locked one isn't paid out unchecked - #1223

Merged
tempus2016 merged 1 commit into
mainfrom
fix/timed-cap-refresh
Nov 4, 2026
Merged

tempus2016 merged 1 commit into
mainfrom
fix/timed-cap-refresh

Conversation

@tempus2016

Copy link
Copy Markdown
Owner

fix(timed): a timer reaching its cap no longer breaks the refresh, and a locked one isn't paid out unchecked

The cap auto-stop runs inside the coordinator's own refresh, and stopping
the session asked for another refresh from in there. Home Assistant's
refresh debouncer isn't re-entrant, so the update failed with "Debouncer
lock is not re-entrant". The stop now takes refresh=False from inside the
update (the running update returns the fresh state), and the stale-session
sweep can skip its refresh the same way.

A running timer whose chore the child can't do any more (a prerequisite
added after it started, a cooldown, a rota or vacation change) still paid
out when it stopped. The completion path would refuse that chore, so the
stopped time now goes to a parent to approve instead of being paid
automatically; the child's time is kept. Pause and Done stay live on the
card so a running session can always be ended.

Testing

  • Unit and frontend tests for this change are included in the diff; the whole batch passes the full suite.
  • Checked on the dev Home Assistant instance as part of the v7.7.1 pre-release gate (desktop and 360/375/393/768 phone/tablet widths).

@github-actions github-actions Bot added documentation Improvements or additions to documentation backend Python integration code tests Test suite labels Nov 4, 2026
@tempus2016
tempus2016 merged commit 7410278 into main Nov 4, 2026
18 checks passed
@tempus2016
tempus2016 deleted the fix/timed-cap-refresh branch November 4, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Python integration code documentation Improvements or additions to documentation tests Test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant