Repository navigation
fix(timed): a timer reaching its cap no longer breaks the refresh, and a locked one isn't paid out unchecked - #1223
Merged
Merged
Conversation
…d a locked one isn't paid out unchecked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(timed): a timer reaching its cap no longer breaks the refresh, and a locked one isn't paid out unchecked
The cap auto-stop runs inside the coordinator's own refresh, and stopping
the session asked for another refresh from in there. Home Assistant's
refresh debouncer isn't re-entrant, so the update failed with "Debouncer
lock is not re-entrant". The stop now takes refresh=False from inside the
update (the running update returns the fresh state), and the stale-session
sweep can skip its refresh the same way.
A running timer whose chore the child can't do any more (a prerequisite
added after it started, a cooldown, a rota or vacation change) still paid
out when it stopped. The completion path would refuse that chore, so the
stopped time now goes to a parent to approve instead of being paid
automatically; the child's time is kept. Pause and Done stay live on the
card so a running session can always be ended.
Testing