Repository navigation
Conversation
|
Revised in cec9d3b. The unsafe annotation-shading patch is removed. The PR now adds a packaged-JAR regression and documents the public annotation dependency. The regression fails with the old patch and passes with annotations preserved; package tests, Checkstyle and formatting pass on current upstream main. The minimal CircleCI job now runs the package tests too. This does not resolve #11236 for applications forcing older Jackson annotations. Final CircleCI49741 passes, including the new package regression and Docker integration; the docs preview also passes. CodeRabbit completed with no actionable comments. |
linghengqian
left a comment
There was a problem hiding this comment.
It’s great that you still remember this PR and the original issue; I honestly have no idea where the maintainers of testcontainers-java have gone over the last two years.😂
8ff30c3 to
f74d167
Compare
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
25382d2 to
cec9d3b
Compare

Add a packaged-JAR regression that verifies the shaded Docker mapper reads
ID,Containers, andDockerRootDirinto the publicInfomodel. Give the JAR tests the existing runtime dependencies needed to exercise that boundary, run them in the minimal CircleCI job, and clarify thatjackson-annotationsremains an unshaded public dependency.Related to #11236. The earlier annotation-shading patch has been removed: it made these fields deserialize as null. This revision provides regression coverage and documentation; support for applications forcing older Jackson annotations remains outside this change, and #11236 is not resolved by it.
Validation: the regression fails against the earlier shading patch and passes with annotations preserved. On current upstream main,
jarFileTestpasses (679 cases, 15 skipped, no failures), and Java/full Spotless checks pass. The combined CI task plan validates with Gradle dry-run. Final CircleCI job49741 passes on cec9d3b. CodeRabbit completed with no actionable comments. Its recorded results confirm the new annotation regression succeeds: 674 tests passed and 16 skipped, including 10 passing Docker integration cases and one Docker skip.