Skip to content

feat(questdb): Append URL parameters in QuestDBContainer.getJdbcUrl() #12074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamedtoukhy03 wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −1
Open

feat(questdb): Append URL parameters in QuestDBContainer.getJdbcUrl() #12074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,21 @@ public String getDriverClassName() {
return "org.postgresql.Driver";
}

@Override
public String getDatabaseName() {
return getDefaultDatabaseName();
}

@Override
public String getJdbcUrl() {
return String.format("jdbc:postgresql://%s:%d/%s", getHost(), getMappedPort(8812), getDefaultDatabaseName());
String additionalUrlParams = constructUrlParameters("?", "&");
return String.format(
"jdbc:postgresql://%s:%d/%s%s",
getHost(),
getMappedPort(POSTGRES_PORT),
getDatabaseName(),
additionalUrlParams
);
}

@Override
Expand Down
24 changes: 24 additions & 0 deletions modules/questdb/src/test/java/org/testcontainers/junit/questdb/SimpleQuestDBTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,30 @@ void testSimple() throws SQLException {
}
}

@Test
void testWithAdditionalUrlParamInJdbcUrl() {
try (
QuestDBContainer questdb = new QuestDBContainer(QuestDBTestImages.QUESTDB_IMAGE)
.withUrlParam("sslmode", "disable")
.withUrlParam("binaryTransfer", "true")
) {
questdb.start();
String jdbcUrl = questdb.getJdbcUrl();
assertThat(jdbcUrl)
.contains("?")
.contains("&")
.contains("sslmode=disable")
.contains("binaryTransfer=true");
}
}

@Test
void testDatabaseName() {
try (QuestDBContainer questdb = new QuestDBContainer(QuestDBTestImages.QUESTDB_IMAGE)) {
assertThat(questdb.getDatabaseName()).isEqualTo("qdb");
}
}

@Test
void testRest() throws IOException {
try (QuestDBContainer questdb = new QuestDBContainer(QuestDBTestImages.QUESTDB_IMAGE)) {
Expand Down