Avoid saving to SRAM when loading preset or savestate - #276
Merged
Conversation
Collaborator
|
If the goal is to cut down on SRAM writes overall, I would axe We should add a comment on the tilegraphics org. I figured it was just a remnant of things moving over time. |
Collaborator
Author
|
Meh, it's fine to leave that. This change came from a review I did of SRAM usage, where I was expecting to find we write to SRAM a lot but we actually weren't. The write-on-load was the only SRAM write I thought was dumb and could be improved. We read from SRAM a lot but it's not a problem to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a couple issues in the next-update branch.
Even though tile tables uses crossbank, the starting value of $E68800 was chosen so each tile table fits within a bank. Starting at $E68000 was causing some issues (try jumping to LN or bubble mountain preset). Also made freespace report the $800 bytes available at the start of bank $E6 (which I had forgotten existed, so nice to know about).