Preset Safeties - #280
Closed
idlechild wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
This idea isn't going away, but I don't think I need a PR just yet. I mentioned trimming KPDR down to two preset categories with safeties, but perhaps going down to just one is possible. For test purposes, I think I'm going to keep all the existing KPDR categories and add a new combined one for the safeties, with the goal of releasing with only the combined category. For now though, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preset safeties allow a single set of category presets to be adjusted to be made safer/easier (or less safe/more difficult). With this approach, instead of having five different KPDR presets, we should be able get down to two (late ice/early ice) yet have more flexibility than before.
This is a work in progress. I'll likely force-push over this commit in the near future. There's a lot of preset calibration still ahead. I only have safeties added to KPDR 20% data (I haven't even renamed the preset files yet), and most safeties were added without consideration to how that impacts later presets (there's likely some strange behavior). A couple safeties are not implemented yet, and I've only defined safeties for KPDR.
It's a start, and I thought it was worth raising a PR for awareness.