Add shortcuts that allow you to save and load two tinystates - #285
Merged
Conversation
Collaborator
|
Its not supported in game over skip, crash handler, or the dev-only option to delete savestates. |
Collaborator
Author
|
Thanks for the feedback; I will look into those. I'm also thinking about making separate read-only locks for the new save states. |
Collaborator
Author
|
Above issues addressed... this might be done? Feedback from those who have tried it is positive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People were kicking around the idea of allowing two tinystates within the full savestates build, and I think it should work. We used to have some differences between fullstate and tinystates, but we've resolved enough differences to make it not that hard to add.
There's probably some things that could be adjusted. Should there be more menu options? Should the new read-only lock state take this into account? I think I'm using the same lockstate for the tinystates; maybe that is fine?
Also included IFB's python changes, which looked fine, but I did notice an issue in defines.asm so I fixed that (actually I think there was an issue in defines.asm that got released but I don't think it would affect most people, and this might be ready to release soon so we can fix it then).