Fix: Celery sync/async DB engines are not disposed after worker fork - #123
Open
Zawiszowski wants to merge 1 commit into
Open
Fix: Celery sync/async DB engines are not disposed after worker fork#123Zawiszowski wants to merge 1 commit into
Zawiszowski wants to merge 1 commit into
Conversation
Zawiszowski
marked this pull request as ready for review
August 21, 2026 07:42
Zawiszowski
force-pushed
the
fix/celery-db
branch
from
August 21, 2026 13:40
2844497 to
ee7d26a
Compare
FBegiello
self-requested a review
August 26, 2026 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
Summary
Celery prefork workers didn't dispose ther inherited DB pool after fork, so children could share the parent's connections instead of building their own. Added a worker_process_init hook that calls dispose(close=False) on both engines so each worker starts with fresh pool.