Repository navigation
Pin the PHP 8.3 docs to a revision from after the 8.3 release - #766
Merged
Merged
Conversation
Collaborator
|
All sounds good, tests pass, merging /o/ FWIW after mentioning "and then we need to check for other regressions" I did make an attempt to automate that process, but it looks like there are hundreds of failures which appear to be mostly false-positives, so that's going to take some work to get to a point where it works reliably D: ( #761 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735
The 8.3 doc-en pin (
7453a503, 2022-11-22) was older than the 8.2 one, so 8.3 got the 8.2 wrappers, includingimagerotate()with the$ignore_transparentparameter removed in PHP 8.0. This pins 8.3 to4b00c791(2023-12-05, two weeks after the 8.3 release, like the 8.4 pin) and doc-base to the latest revision of that day (59bc2bb7).Checking for regressions (as suggested by @shish 😄)
masterwithout this change reproduces the committedgenerated/exactly, so the diff only reflects the new pin.odbc_autocommit(), only gets\Odbc\Connectionfrom 8.4, as expected.shuffle(),syslog(),closelog(),phpinfo(),phpcredits()andsodium_crypto_generichash_update()are declared: true, andgzpassthru(),inflate_get_status(),mb_encoding_aliases()andcurl_multi_init()never returnfalse, so thethrowthey lose could never fire.posix_eaccess()andstream_context_set_options()were missing for 8.3 users.date_create_immutable()andftp_nb_get()are now wrapped and are indeed|falseon 8.3.posix_getrlimit(?int $resource),pg_trace(..., $trace_mode)andassert_options(int $option)now match 8.3.imagerotate(),xml_*,imap,pspell,pgsql,db2,odbc.Eleven
generated/8.4/files go away because they are now identical to their 8.3 counterparts.Tests pass on PHP 8.5 (48 tests). On 8.3 I could only lint the generated files and smoke-test a few wrappers, since PHPUnit needs
ext-domthere.