[ujfalusi]

The fw_profile/tplg_name debugfs file exposes the topology file name selected
for the platform. When function topologies are used, the selected name is a
placeholder (sof-<platform>-dummy.tplg) which does not tell which topology
files have actually been loaded.

The second patch replaces the static name with a list of the loaded topology
files, one per line (the topology path prefix is dropped as it is exposed via
fw_profile/tplg_path). The list is set after a successful topology load and
cleared again when the loading fails or the topology is removed; while no
topology is loaded the selected topology name is shown. For monolithic
topologies the content of the file is unchanged.

The first patch is a preparatory fix: snd_sof_load_topology() can fail after
one or more topology files have been loaded (subsequent request_firmware(),
feature topology path allocation, sof_complete(), snd_ctl_led_request()),
but the loaded topology objects were only removed when
snd_soc_tplg_component_load() itself failed. Since the component remove
callback is not called for a failed probe, they were left behind referencing
freed DAPM data. Remove the topology on any load error.

Example with function topologies:

# cat /sys/kernel/debug/sof/fw_profile/tplg_name
sof-ptl-sdca-jack-id0.tplg
sof-ptl-sdca-2amp-id2.tplg
sof-ptl-dmic-4ch-id4.tplg
sof-ptl-hdmi-pcm5-id5.tplg

Note: tools reading tplg_name and expecting a single file name will get
multiple lines on function topology systems (the dummy name never existed on
disk, so such tools did not work there before either).

[Copilot]

🟡 Changes recommended

Concurrent debugfs reads can access freed memory, and unchecked allocation failures can publish incomplete topology lists.

2 open issues

• Race between debugfs reads and tplg_name replacement · New
• Unchecked allocation failures publish incomplete topology file lists · New

What changed in this PR

This PR updates SOF’s fw_profile/tplg_name debugfs entry to report loaded topology files rather than a placeholder when function topologies are used.

Changes:

• Collect loaded topology filenames, separated by newlines and without the shared path prefix.
• Publish the collected list after successful topology completion, retaining the selected name as the initial value.

File	Description
sound/​soc/​sof/​topology.c	Collects filenames and publishes the loaded topology list.
sound/​soc/​sof/​sof-priv.h	Adds storage for the loaded topology names.
sound/​soc/​sof/​debug.c	Initializes the name storage and exposes it through debugfs.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Both new name-allocation failure paths leave loaded topology objects behind during failed-probe cleanup, creating dangling references.

3 open issues

• Clean up topology when name allocation fails · New
• Unload feature topology on name allocation failure · New
• Race between debugfs reads and tplg_name replacement

1 resolved since last review

• Unchecked allocation failures publish incomplete topology file lists

_{Review effort: Balanced}

[ujfalusi]

Changes since v1:

• add lock to cover the race for accessing tplg_name (use a function to print the string)
• error handling for the string allocation
• Clear the loaded topology names on card unbind

@harajend , this might impact CI as now with function (and feature) topologies the tplg_name will contain all the loaded topology files in the order they were loaded.
It could help in CI to identify what is loaded and this information can be used to recreate the full topology picture with tplgtool2.py -m to merge the multiple files for a full system view

[ujfalusi]

Changes since v2:

• New patch: "ASoC: SOF: topology: Remove loaded topologies on load failure"
  • addresses the Copilot review on v2: snd_sof_load_topology() errors after
    a topology file has been loaded (subsequent request_firmware(), feature
    topology path allocation, sof_complete(), snd_ctl_led_request() and the
    new name allocation) left the loaded topology objects behind as the
    component remove callback is not called for a failed probe
  • call snd_soc_tplg_component_remove() on any load error, a second call
    after a snd_soc_tplg_component_load() failure is a no-op
  • drop the comments claiming cleanup on request_firmware() failure
  • Fixes: 6d5997c ("ASoC: SOF: topology: load multiple topologies")
• tplg_name patch:
  • also clear the published list on load failure (relevant when
    snd_ctl_led_request() fails after the list was published)
  • commit message updated accordingly

[Copilot]

🔵 Needs a closer look

Expanded failed-probe cleanup and device-lifetime interactions need human validation across partial topology loads and completion failures.

1 open issue

• Race between debugfs reads and tplg_name replacement

2 resolved since last review

• Unload feature topology on name allocation failure
• Clean up topology when name allocation fails

_{Review effort: Balanced}