Skip to content

audio: module_adapter: always set init_data in module_adapter_init_data #10966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

audio: module_adapter: always set init_data in module_adapter_init_data #10966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/audio/module_adapter/module_adapter_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,13 @@ int module_adapter_init_data(struct comp_dev *dev,
}
}

/* Assume legacy API if module data was not found in ext_init payload */
if (!config->ipc_extended_init || !dst->ext_data->module_data) {
dst->init_data = cfg; /* legacy API */
/* Always provide init_data so legacy modules have a valid pointer.
* Extended-init-aware modules (e.g. cadence) read
* ext_data->module_data directly and never dereference init_data.
*/
dst->init_data = cfg;
if (!config->ipc_extended_init || !dst->ext_data->module_data)

@lyakh lyakh Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the chance and add a comment, that cfg is usually pointing to the mailbox, so it cannot be used persistently, but it's reset later in module_adapter_new_ext() by calling module_adapter_reset_data()

dst->avail = true;
}

return 0;
}
Expand Down
Loading