Repository navigation
A series of potential bug fixes for DAX module - #11320
Merged
Merged
Conversation
added 4 commits
October 19, 2026 18:10
Remove dead null-check in sof_dax_process(). Signed-off-by: Jun Lai <junlai@dolby.com>
Initialize the instance manager from static data instead of using an unguarded runtime check. Remove the obsolete initializer and its call. Signed-off-by: Jun Lai <junlai@dolby.com>
Replace the shared static parameter-formatting buffer with per-instance storage. Pass that storage through get_params_str() to avoid concurrent calls overwriting each other across module instances. Signed-off-by: Jun Lai <junlai@dolby.com>
Recognize tuning-parameter blob configuration ID and reject unsupported configuration IDs. For IPC3, process zero-size SET_VALUE controls convert the volume format. Signed-off-by: Jun Lai <junlai@dolby.com>
Collaborator
|
Can one of the admins verify this patch?
|
checkupup
force-pushed
the
main_dax_fixes
branch
from
October 21, 2026 14:56
aadb750 to
f70f60c
Compare
checkupup
changed the title
checkupup
marked this pull request as ready for review
October 21, 2026 14:58
checkupup
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 21, 2026 14:58
lgirdwood
approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes match the surrounding contracts, with no blocking issues identified in static review.
No open issues 🎉
What changed in this PR
This PR improves DAX configuration handling and removes shared-state initialization and logging hazards.
Changes:
- Handles IPC3 controls, converts volume values, and rejects unsupported configuration identifiers.
- Moves parameter logging storage into each DAX instance.
- Statically initializes the instance manager and checks adapter data before dereferencing it.
| File | Description |
|---|---|
src/audio/module_adapter/module/dolby/dax.h |
Adds per-instance logging storage and removes the obsolete initializer declaration. |
src/audio/module_adapter/module/dolby/dax.c |
Updates configuration handling, logging, and null-check ordering. |
src/audio/module_adapter/module/dolby/dax_instance_manager.c |
Replaces runtime initialization with static initialization. |
Review effort: Balanced
Member
|
DAX module not tested by pending CIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of tiny fixes for DAX module:
aadb750ea—dax: fix IPC3 configuration issuesRecognizes the tuning-parameter blob configuration ID, rejects unsupported configuration IDs, and handles IPC3 zero-size
SET_VALUEcontrols and volume-format conversion.b4b05d6ef—dax: isolate DAX parameter logging bufferReplaces a shared static formatting buffer with per-instance storage to prevent concurrent calls from overwriting one another’s output.
915233ae8—dax: avoid DAX manager initialization raceInitializes the instance manager from static data, removing the unguarded runtime initialization check and its obsolete initializer.
a7015c3f7—dax: remove invalid null-checkRemoves the dead null check in
sof_dax_process().