Skip to content

ipc4: handler: bound large config get reply size #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Oct 22, 2026
Merged

ipc4: handler: bound large config get reply size #11327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/ipc/ipc4/handler-user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,12 @@ __cold static int ipc4_process_large_config_get(struct ipc4_message_request *ipc
if (ret)
return ret;

/* A module must not report more reply data than the DSP mailbox can hold. */
if (data_offset > MAILBOX_DSPBOX_SIZE) {
ipc_cmd_err(&ipc_tr, "reply size %u exceeds mailbox bound", data_offset);
return IPC4_INVALID_CONFIG_DATA_STRUCT;
}

/* Output via parameters instead of msg_reply */
*reply_ext = reply.extension.dat;
*reply_tx_size = data_offset;
Expand Down Expand Up @@ -1292,6 +1298,12 @@ __cold static int ipc4_get_large_config_module_instance(struct ipc4_message_requ
if (ret)
return ret;

/* A module must not report more reply data than the DSP mailbox can hold. */
if (data_offset > MAILBOX_DSPBOX_SIZE) {
ipc_cmd_err(&ipc_tr, "reply size %u exceeds mailbox bound", data_offset);
return IPC4_INVALID_CONFIG_DATA_STRUCT;
}

msg_reply->extension = reply.extension.dat;
msg_reply->tx_size = data_offset;
msg_reply->tx_data = data;
Expand Down
Loading