Repository navigation
audio: dcblock: use size_t for processing counts and unsigned channel counts - #11336
Open
softwarecki wants to merge 2 commits into
Open
softwarecki wants to merge 2 commits into
softwarecki wants to merge 2 commits into
Conversation
Switch the processing function frame argument and the per-call sample and byte counters to size_t so they match the sink/source API and no longer truncate wide counts. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Store and iterate the channel count as unsigned int to match the stream channel count type. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
lgirdwood,
piotrhoppeintel,
serhiy-katsyuba-intel,
tmleman and
wjablon1
October 22, 2026 20:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped type changes are consistent across the callbacks and implementations, with no unresolved correctness issues identified.
No open issues 🎉
What changed in this PR
This PR aligns DC-block processing counts and channel types with the sink/source APIs, removing narrowing conversions across the component’s processing implementations.
Changes:
- Use
size_tfor frame counts, affected sample counts, and processing indices. - Use unsigned channel counts and channel indices.
- Keep callback signatures consistent across generic, ARM, HiFi3, and HiFi4 implementations.
| File | Description |
|---|---|
src/audio/dcblock/dcblock.h |
Updates the callback signature, channel field, and function-map index types. |
src/audio/dcblock/dcblock.c |
Preserves API frame counts as size_t. |
src/audio/dcblock/dcblock_hifi4.c |
Aligns processing signatures and frame/channel indices. |
src/audio/dcblock/dcblock_hifi3.c |
Widens sample counters and aligns frame/channel types. |
src/audio/dcblock/dcblock_generic.c |
Aligns processing signatures and channel types. |
src/audio/dcblock/dcblock_arm.c |
Widens sample counters and indices and aligns channel types. |
Review effort: Balanced
PR 11336: test resultsRun date: 2026-10-22 21:52 UTC Tested commit: 8945a7bafdbffd13623287e7ede4a0f8f1a2bbf4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert frame, sample and byte counts to
size_t, and useunsignedchannel counts to match the sink/source API and stream types. Remove narrowing of wide processing counts.