Skip to content

topology2: add function topology description - #11340

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
bardliao:function-topology-readme
Oct 23, 2026
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
bardliao:function-topology-readme

Conversation

@bardliao

Copy link
Copy Markdown
Collaborator

Add function topology description in the README file.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 06:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only addition matches the stated purpose and has only an optional grammar correction.

1 open issue
What changed in this PR

Adds guidance on function topologies to the topology2 README, explaining their shared role across devices with the same audio function.

Changes:

  • Defines function topologies and gives examples of supported functions.
  • Describes ACPI-based selection by the Linux kernel driver.
  • States that function topologies should not contain customized features.
File Description
tools/​topology/​topology2/​README.md Documents function topology purpose, selection, and customization constraints.

Review effort: Balanced

Comment thread tools/topology/topology2/README.md Outdated
@bardliao
bardliao force-pushed the function-topology-readme branch from 4f70f0f to 72734ca Compare October 23, 2026 06:34

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @bardliao . A few typos. We can extend this if the function topology role increases.

Comment thread tools/topology/topology2/README.md Outdated
Comment thread tools/topology/topology2/README.md Outdated
Add function topology description in the README file.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao
bardliao force-pushed the function-topology-readme branch from 72734ca to 71cdd09 Compare October 23, 2026 10:40
@lgirdwood

Copy link
Copy Markdown
Member

Not tested by CI

@lgirdwood
lgirdwood merged commit 335f7ee into thesofproject:main Oct 23, 2026
43 of 44 checks passed
@intel-sofci

Copy link
Copy Markdown

PR 11340: test results

Run date: 2026-10-23 12:41 UTC

Tested commit: 71cdd09ce6460d1076506d4e07effddfea9e222d

mtl pass rate lnl pass rate ptl pass rate wcl pass rate nvl pass rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants