Repository navigation
audio: iadk: add timestamping service provider - #11341
Open
abonislawski wants to merge 1 commit into
Open
abonislawski wants to merge 1 commit into
abonislawski wants to merge 1 commit into
Conversation
abonislawski
requested review from
serhiy-katsyuba-intel
and
a balanced review from Copilot
October 23, 2026 07:39
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
October 23, 2026 07:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the specified compatibility behavior, with no blocking issues identified in the interface, service integration, or build registration.
No open issues 🎉
What changed in this PR
Adds an IADK TimestampingInterface v1 compatibility provider and connects it to the existing module-adapter service lookup.
Changes:
- Defines the timestamping interface and module counter structure.
- Implements zeroed current-position counters and accepts only zero-shift adjustments, leaving supplied counters unchanged.
- Registers the provider in versioned and unversioned service lookups and the IADK build.
| File | Description |
|---|---|
| src/include/sof/audio/module_adapter/iadk/timestamping_interface.h | Defines the v1 interface and counter structure. |
| src/include/sof/audio/module_adapter/iadk/iadk_timestamping_service.h | Declares the provider lookup function. |
| src/audio/module_adapter/iadk/timestamping_service_provider.cpp | Implements compatibility behavior and version validation. |
| src/audio/module_adapter/iadk/system_agent.cpp | Routes timestamping service requests to the provider. |
| src/audio/module_adapter/CMakeLists.txt | Includes the provider in the IADK build. |
Review effort: Balanced
serhiy-katsyuba-intel
approved these changes
Oct 23, 2026
Provide the IADK TimestampingInterface v1 compatibility provider with zeroed counters. GetCurrentPosition clears all counters, while AdjustPosition accepts only a zero shift and leaves the supplied counters unchanged. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
timestamping_service
branch
from
October 23, 2026 08:10
249383f to
23ca645
Compare
PR 11341: test resultsRun date: Tested commit: 23ca645fc5873fd3dbed5352a9541a012b3d7130
|
lgirdwood
approved these changes
Oct 23, 2026
Member
|
@abonislawski can you check CI, I think the failures are probably unrelated to the PR. |
kv2019i
approved these changes
Oct 23, 2026
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Is the plan to follow-up with non-zero counters at some point...?
Member
Author
|
@kv2019i yes, it will be added later; very low priority for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide the IADK TimestampingInterface v1 compatibility provider with zeroed counters. GetCurrentPosition clears all counters, while AdjustPosition accepts only a zero shift and leaves the supplied counters unchanged.