Repository navigation
Conversation
zephyr_dp_schedule_application.c maps the IPC host box into the DP thread memory domain using MAILBOX_HOSTBOX_BASE and MAILBOX_HOSTBOX_SIZE, but it got their definitions from sof/audio/pipeline.h, which no longer includes sof/lib/mailbox.h. Builds with CONFIG_SOF_USERSPACE_APPLICATION, i.e. CONFIG_USERSPACE without CONFIG_SOF_USERSPACE_PROXY, fail since: error: use of undeclared identifier 'MAILBOX_HOSTBOX_BASE' Include sof/lib/mailbox.h directly. Fixes: c8d05c2 ("audio: pipeline: do not include the mailbox header from pipeline.h") Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
requested review from
LaurentiuM1234,
dbaluta,
marcinszkudlinski and
pblaszko
as code owners
October 23, 2026 13:12
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line include restores a required dependency, with no unresolved findings or runtime logic changes.
No open issues 🎉
What changed in this PR
Fixes the application scheduler build regression introduced by #11330 by explicitly including the header that supplies its mailbox definitions.
Changes:
- Adds
sof/lib/mailbox.hdirectly, restoring builds withCONFIG_SOF_USERSPACE_APPLICATIONwithout changing runtime behavior.
| File | Description |
|---|---|
src/schedule/zephyr_dp_schedule_application.c |
Adds the header required for existing host mailbox references. |
Review effort: Balanced
PR 11346: test resultsRun date: 2026-10-23 13:52 UTC Tested commit: 14d2ccb0dec10370f5d53bfb331ae14376155c37
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a build regression from #11330. With
CONFIG_SOF_USERSPACE_APPLICATION(CONFIG_USERSPACEwithoutCONFIG_SOF_USERSPACE_PROXY), the build fails with:zephyr_dp_schedule_application.cgot the host box definitions throughsof/audio/pipeline.h, which no longer includessof/lib/mailbox.hsince c8d05c2. This change includessof/lib/mailbox.hdirectly.Tested by building PTL with
CONFIG_SOF_USERSPACE_PROXY=n. The build passes at c8d05c2~1, fails at c8d05c2 and on current main, and passes with this change. CI doesn't build this configuration (all CI and overlay builds use the userspace proxy), which is why it was missed.🤖 Generated with Claude Code