Repository navigation
Conversation
The code uses MAILBOX_HOSTBOX_BASE and MAILBOX_HOSTBOX_SIZE, but relies on <sof/lib/mailbox.h> to be included indirectly. This breaks when the indirect include chain changes. With latest Zephyr, the PTL build fails with: error: use of undeclared identifier 'MAILBOX_HOSTBOX_BASE' Fix by including the header explicitly. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
LaurentiuM1234,
dbaluta,
marcinszkudlinski and
pblaszko
as code owners
October 23, 2026 13:34
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-header addition directly addresses the missing dependency, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds an explicit mailbox header dependency to the Zephyr application scheduler, addressing the reported PTL build failure when indirect includes change.
Changes:
- Includes
<sof/lib/mailbox.h>directly forMAILBOX_HOSTBOX_BASEandMAILBOX_HOSTBOX_SIZE, without changing runtime behavior.
| File | Description |
|---|---|
src/schedule/zephyr_dp_schedule_application.c |
Adds the header providing the mailbox definitions used by the scheduler. |
Review effort: Balanced
PR 11349: test resultsRun date: 2026-10-23 14:22 UTC Tested commit: 8f7e13796755cecc4f367b82dc9b1295dd083b7a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code uses MAILBOX_HOSTBOX_BASE and MAILBOX_HOSTBOX_SIZE, but relies on <sof/lib/mailbox.h> to be included indirectly. This breaks when the indirect include chain changes. With latest Zephyr, the PTL build fails with:
error: use of undeclared identifier 'MAILBOX_HOSTBOX_BASE'
Fix by including the header explicitly.