fix: allow lang-core postinstall in template pnpm allowlists - #943
Open
Aditya-thesys wants to merge 1 commit into
Open
fix: allow lang-core postinstall in template pnpm allowlists#943Aditya-thesys wants to merge 1 commit into
Aditya-thesys wants to merge 1 commit into
Conversation
lang-core 0.2.11 added an install-telemetry postinstall script; pnpm 11 fails installs whose build scripts are not allowlisted, breaking every pnpm@11 CI matrix job for both templates. Add lang-core to all three per-pnpm-version allowlist locations in each template.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm@11 template CI jobs are failing repo-wide with:
Cause:
@openuidev/lang-core@0.2.11(published Aug 5) added an install-telemetrypostinstallscript — 0.2.10 had none. pnpm 11 hard-fails installs whose dependency build scripts are not allowlisted, and the template allowlists only coveredsharpandunrs-resolver.Fix: add
@openuidev/lang-coreto the allowlist in both templates, in all three per-pnpm-version locations the existing comment documents (package.jsonpnpmfield for <=10.13,onlyBuiltDependenciesin pnpm-workspace.yaml for 10.14-10.x,allowBuildsfor >=11). The postinstall is first-party and intentionally added, so allowing it (rather than ignoring) preserves the telemetry.Unblocks #942 and any other PR currently red on the
openui-cloud (pnpm@11, *)/openui-self-hosted (pnpm@11, *)matrix jobs.