Repository navigation
ci: audit only the runtime dependencies with pip-audit - #181
Merged
Merged
Conversation
pip-audit ran against the whole dev environment, so a CVE in a dev-only tool failed every build. filelock (pulled in by pre-commit via virtualenv, and by pip-audit itself via cachecontrol) has CVEs whose fix needs Python >= 3.11, so the 3.10 jobs could never pass. Audit an export of the locked runtime dependencies instead: that is what ships with git-nested. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 2122 2122
=========================================
Hits 2122 2122 |
This was referenced Oct 25, 2026
thorsten-klein
added a commit
to thorsten-klein/venv-patcher
that referenced
this pull request
Oct 25, 2026
Fixes the failing `Run Tests` workflow on `main` (https://github.com/thorsten-klein/venv-patcher/actions/runs/40121226763). The `pip-audit` task audited the whole dev environment, so a CVE in a dev-only tool failed the build. `filelock` (pulled in by `pre-commit` → `virtualenv`, and by `pip-audit` → `cachecontrol[filecache]`) has CVEs (CVE-2026-112907, -112913, -112940) and the fix is in 4.2.1, which needs Python >= 3.11. filelock never ships with the package. ## Change `poe pip-audit` now audits a `uv export --no-default-groups` of the lock, so only the runtime dependencies that ship (currently PyYAML) are checked. The export keeps environment markers, so the audit covers the Python it runs on. Same change as thorsten-klein/git-nested#181. ## Testing - `poe all` passes locally (149 passed, 1 skipped). - The old task still reports the 3 filelock CVEs on the current lock. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
Run Testsworkflow (e.g. https://github.com/thorsten-klein/git-nested/actions/runs/40121601902), which also blocks #179 and #180.Problem
poe pip-auditaudited the whole dev environment.filelock 3.32.3has CVEs (CVE-2026-112907, -112913, -112940) and the fix is in 4.2.1, which needs Python >= 3.11. On 3.10 the newest version is 4.1.0, which has three more CVEs. filelock is dev-only. It comes in throughpre-commit→virtualenvand throughpip-audit→cachecontrol[filecache], and it never ships with git-nested.Change
The
pip-audittask now audits auv export --no-default-groupsof the lock, so only the runtime dependencies that ship (currently PyYAML) are checked. The export keeps environment markers, so each Python version in CI audits its own resolved set.Testing
poe allpasses locally on 3.12.poe pip-auditpasses on 3.10 and 3.12.🤖 Generated with Claude Code