Repository navigation
Make a copy of map items during iteration so it's threadsafe - #3634
Merged
peterebden merged 3 commits intoOct 15, 2026
Merged
Conversation
toastwaffle
approved these changes
Oct 14, 2026
| } | ||
|
|
||
| // Items returns a copy of all the items currently in the shard (not including those that are not complete yet). | ||
| func (s *shard[K, V]) Items() []item[K, V] { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *shard[K, V]) Items() []item[K, V] { | |
| func (s *shard[K, V]) items() []item[K, V] { |
nit, mostly based on the "exported methods/functions should not return unexported types". Sort of doesn't apply because the method is itself on an unexported type anyway, but...
Collaborator
Author
There was a problem hiding this comment.
Yeah fair - I kind of prefer it this way though as an (unenforced of course) indicator that other things in the package are ok to call this (vs. mucking with shard members directly).
Point taken on the unexported type, but of course receivers in this package can name it which is the usual objection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save some worries about potential deadlocks if these functions don't have that limitation any more. We don't call these functions on a hot path so allocating one slice per shard shouldn't cost much.