Repository navigation
Pass context down to pre/post build functions - #3635
Open
peterebden wants to merge 4 commits into
Open
peterebden wants to merge 4 commits into
peterebden wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a little lazy, to reinvent a
context.Background()in the middle of things. This plumbs it through so it doesn't need to get a new one.There's a potential edge case involving one of these being needed for a preload and triggering more parses which now lack the correct context info. It seems fairly niche but possible that such a thing might happen somewhere (hyrum's law etc).