[pull] master from apify:master - #318
Merged
Merged
Conversation
…4132) `discoverValidSitemaps` builds the well-known sitemap candidates by reassigning `pathname` on a `URL` parsed from the domain's first input URL. `search` and `hash` survive that reassignment, so a seed like `https://example.com/products?page=2#top` is probed as: ``` https://example.com/sitemap.xml?page=2 https://example.com/sitemap.txt?page=2 https://example.com/sitemap_index.xml?page=2 ``` A server that keys on the full path-and-query answers those with a 404, and discovery silently finds nothing for a domain that does have a sitemap. A server that ignores the query answers 200, and the query-carrying URL is then what gets yielded and loaded as the sitemap. Clearing `search` and `hash` before setting the pathname fixes both. Userinfo and port are left alone, so sites behind basic auth or on a non-default port keep working as before.
Co-authored-by: Jan Buchar <jan@buchar.dev>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )