[pull] master from google:master - #225
Merged
Merged
Conversation
We're currently doing excessive objdump calls in the bad build check. We only need it once to calculate the sanitizer keywords. Also adjust all.sh so it's no longer needed to set up specific Python packages to build the base images. This also makes it very easy to quickly adjust which base images to build by modifying the file. This is how it was earlier which IMO works better when adjusting the base images. --------- Signed-off-by: David Korczynski <david@adalogics.com>
This PR fixes the base docker image for project fwupd. Since 27th August, the upstream fwupd repository includes the rust cargo build process as part of the fuzzer build. But the base building image has no cargo installed and cause building error from 27th August. this PR fixes the problem but switching the base building to the rust alternative to accommodate the new rust cargo build process enabled from the upstream repository. Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )