Skip to content

Complete the management API functions and add application components #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brionmario wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Complete the management API functions and add application components #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion packages/better-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@thunderid/eslint-plugin": "catalog:",
"@thunderid/prettier-config": "catalog:",
"@types/node": "catalog:",
"better-auth": "^1.7.2",
"better-auth": "^1.7.13",
"eslint": "catalog:",
"prettier": "catalog:",
"rimraf": "catalog:",
Expand Down
3 changes: 1 addition & 2 deletions packages/better-auth/src/__tests__/thunderid.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('thunderid', () => {
});

expect(config.providerId).toBe('thunderid');
expect(config.accountIssuer).toBe('https://thunderid.example.com');
expect(config.requireIdTokenVerification).toBe(true);
expect(config.discoveryUrl).toBe('https://thunderid.example.com/.well-known/openid-configuration');
expect(config.scopes).toEqual(['openid', 'profile', 'email']);
expect(config.clientId).toBe('thunderid-client-id');
Expand All @@ -30,7 +30,6 @@ describe('thunderid', () => {
issuer: 'https://thunderid.example.com/',
});

expect(config.accountIssuer).toBe('https://thunderid.example.com');
expect(config.discoveryUrl).toBe('https://thunderid.example.com/.well-known/openid-configuration');
});

Expand Down
4 changes: 3 additions & 1 deletion packages/better-auth/src/thunderid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,10 @@ export function thunderid(options: ThunderIDOptions): GenericOAuthConfig<'thunde

return {
providerId: 'thunderid',
accountIssuer: issuer,
discoveryUrl: `${issuer}/.well-known/openid-configuration`,
// Without the discovered issuer and keys, ID tokens could not be verified, so the provider is
// not registered rather than signing users in on unverified tokens.
requireIdTokenVerification: true,
clientId: options.clientId,
clientSecret: options.clientSecret,
tokenEndpointAuth: options.tokenEndpointAuth,
Expand Down
Loading
Loading