fix: derive IdC OIDC region from device registration, not profile ARN - #126
Open
haxrob wants to merge 1 commit into
Open
fix: derive IdC OIDC region from device registration, not profile ARN#126haxrob wants to merge 1 commit into
haxrob wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for token refresh issue for when the Q profile and Identity Center are in different regions. Here the refresh reaches a regional endpoint that never issued the device registration and fails with HTTP 400 Invalid token provided. As such, tokens last an hour, so sessions start fine and break mid-session.
syncFromKiroCli sets oidcRegion = serviceRegion, where serviceRegion is derived from the Q Developer profile ARN. refreshAccessToken then POSTs the Identity Center refresh to https://oidc..amazonaws.com/token.
isValidRegion is used rather than normalizeRegion because the latter returns us-east-1 for unrecognised input, which would substitute a wrong region instead of falling back.
region still comes from the ARN, so the q..amazonaws.com inference endpoint is unchanged.