Skip to content

fix: show matched memory count during search - #290

Merged
lindixu6-hash merged 1 commit into
tickernelz:mainfrom
amandeavor:fix/search-result-count
Aug 30, 2026
Merged

fix: show matched memory count during search#290
lindixu6-hash merged 1 commit into
tickernelz:mainfrom
amandeavor:fix/search-result-count

Conversation

@amandeavor

Copy link
Copy Markdown
Collaborator

Summary

  • show the search result total while a query is active
  • restore the store-wide total when the query is cleared
  • cover matched, zero-result, and cleared-search states with regression tests

Closes #288

Validation

  • bun test tests/memory-count.test.ts (2 passed)
  • bun run typecheck
  • production web build
  • Prettier check on changed files
  • git diff --check

Copilot AI lite review requested due to automatic review settings August 30, 2026 13:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@lindixu6-hash lindixu6-hash left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the search/count state flow and the extracted helper. The active-search path uses the API result total, clearing search restores the store-wide stats total, and zero-result search remains distinguishable from the unfiltered state. Local verification: targeted test 2/2, full suite 449/449 with 1 skip, typecheck, and production build all pass at 9fca346.

@lindixu6-hash
lindixu6-hash merged commit f5033a8 into tickernelz:main Aug 30, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show matched memory count while Web UI search is active

3 participants