The sweep's page list and gating modes each have one source - #103
Merged
Conversation
`--list-pages` prints the page list the run sweeps, one path per line, so `--pages` replaces it there as in every other mode. `--list-gating` prints the six gating invocations as full command lines, from a new `gating` vector that is now the one declaration of them. Both exit 0 and the header's Modes block documents them.
The block held its own copy of the six page paths and of the six gating invocations. It now takes both from `--list-pages` and `--list-gating` and names no page path. What it states on its own is their shape: six pages that exist on disk, six invocations, one carrying no flag and three reading the roxygen sources, so a list that emptied or lost a mode is still a failure. Both reads were shown able to fail. Swapping `--plain` for `--openings` in the script's `gating` vector turned the block red naming that mode, and dropping a page from `pages` turned it red on the count.
The `consistency-gate` slot spelled the six gating sweeps out. It now tells the reader to run each command `--list-gating` prints and says the script owns the list. The `verify` slot's two plain modes stay as they are, a deliberate subset rather than a copy.
Compared `--list-gating` against the workflow's `run:` lines: the two outputs are identical, six lines in the same order, and the job carries no other sweep step. The step comment now names the script's `gating` vector as the one declaration and these steps as its one accepted copy, kept so a red run names the mode on the job summary.
`devtools::test()` clean at 9862 passing. `devtools::check()` reports 0 errors, 0 warnings and 0 notes. The six gating sweeps each print `clean` and exit 0, and `air format --check` passes on both touched R files. Claim audit not owed: internal surface tier.
…and header reworded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmarks/sweep-prose.R gains two listing modes.
--list-pagesprints the page list and--list-gatingprints the six gating sweep commands, one per line.The real-pages block of tests/testthat/test-sweep-prose.R now reads both lists from the script instead of keeping its own copies. It still checks their shape: six unique pages that exist, and six unique invocations, one with no flag and three reading the roxygen sources. The profile's gate line points at
--list-gating, and the comment in .github/workflows/prose-sweep.yaml says the script owns the list its six steps copy.Local checks: devtools::test() passes 9862 with 0 failures, devtools::check() reports 0 errors, 0 warnings and 0 notes, and the six gating sweeps print clean.