Docs: the nested estimate is the number to report for the deployed model - #104
Merged
Conversation
…for the deployed model
…he full check, still running
…ck to in-progress
…-progress with T9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README, the four guides, the final-fit help pages and the final-fit print now state the nested estimate from
collect_metrics()as the number to report for the model you deploy. The reason given is that the estimate describes the tune-and-fit procedure, and the deployed model is that procedure run on all the data.vignette("estimate")open with why a single test-split score is one number from one split, and what the outer folds add.print.nested_final_fit()andsummary()show the new message from one constant, with tests that match both of its facts.?nested_final_fit,?print.nested_final_fit,?summary.nested_final_fit,?nested_tune_gridand related pages reworded to match.