Doc 2403 run query endpoint - #966
Conversation
|
|
||
| [NOTE] | ||
| ==== | ||
| If you only need to run an installed query, TigerGraph recommends using the RESTPP endpoint `GET /query/{graph_name}/{query_name}` for lower request overhead. |
There was a problem hiding this comment.
"only need to run an installed query"
"only" is in comparison to what? What are these others things that this GSQL endpoint could do?
Clarified the usage of RESTPP and GSQL endpoints for running installed queries.
PR Review Agent verdict: 🔴 request_changesThis is an automated review agent's judgement. False alarm? React 👎 on this comment to flag it for other reviewers. Open issues (2)🟠 Major (1)
🟡 Minor (1)
|
|
|
||
| [NOTE] | ||
| ==== | ||
| This endpoint performs the same core function as the RESTPP endpoint `GET /query/{graph_name}/{query_name}`. |
There was a problem hiding this comment.
🟠 [major]
The NOTE block in both changed files fails to meet the core requirements of DOC-2403. The ticket and Victor Lee's explicit instructions require the docs to explain why two endpoints exist and the tradeoffs between them. Specifically: the GSQL endpoint (POST /gsql/v1/queries/{queryName}) internally forwards the request to RESTPP, adding an extra hop and latency. The RESTPP endpoint (GET /restpp/query/{graph_name}/{query_name}) handles the query directly with less overhead. The docs should frame the GSQL endpoint as a wrapper provided for API consistency and advise users optimizing for latency to use the RESTPP endpoint directly.
The current NOTE blocks only state that the two endpoints "perform the same core function" and "if you already use one, keep using it." This does not give a new user any basis for choosing between them.
Suggested fix: On the GSQL page (the wrapper), add text such as: "This endpoint is a wrapper that forwards the request internally to the RESTPP endpoint. It is provided as part of the standardized GSQL API for consistency with other GSQL endpoints. Users who need to minimize latency and server traffic should use the RESTPP endpoint directly." On the RESTPP page, note that it is the canonical/direct endpoint with lower overhead, and cross-reference the GSQL wrapper.
|
|
||
| [NOTE] | ||
| ==== | ||
| This endpoint performs the same core function as the RESTPP endpoint `GET /query/{graph_name}/{query_name}`. |
There was a problem hiding this comment.
🟡 [minor]
The NOTE cites the RESTPP endpoint as `GET /query/{graph_name}/{query_name}` but the actual endpoint (documented on the built-in-endpoints page, line 2531) is `GET /restpp/query/{graph_name}/{query_name}`. The /restpp prefix is missing. A reader who copies this path directly would get a 404.
Suggested fix: `GET /restpp/query/{graph_name}/{query_name}`
PR Review —
|
No description provided.