Conversation
The script claimed "same config as CI" while passing -severity medium and installing gosec@latest. The workflow pins v2.28.0 and applies no severity filter, so the local check could pass on code CI rejects — which is exactly what happened on the extension-dispatch branch: a HIGH-severity G702 taint finding was invisible locally and failed in CI. Pins the same version and drops the severity filter. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014aqbmccWm1tqttmBUCR5rv ClickUp: 86dxbeqyt
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ci.shsays it runs gosec "with same config as CI". It does not:v2.28.0gosec@latest-severity mediumSo a local run could pass on code CI rejects. That is not hypothetical — it happened on #53: a HIGH-severity
G702taint finding was invisible locally and failed in CI. (The severity filter alone would not have hidden a HIGH finding; the unpinned version is what did, since@latestandv2.28.0disagree about which rules exist.)This pins the same version and drops the filter, so a green local run means a green CI run.
Checklist
./scripts/ci.shpasses locally — excepterrcheck, which reports the same pre-existing findings onmain