Skip to content

remove env set for XDEBUG - #136

Open
tijmenbruggeman wants to merge 1 commit into
tinify:masterfrom
wcreateweb:chore/remove-env-set
Open

tijmenbruggeman wants to merge 1 commit into
tinify:masterfrom
wcreateweb:chore/remove-env-set

Conversation

@tijmenbruggeman

@tijmenbruggeman tijmenbruggeman commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Do not set defaults for XDEBUG

Summary by CodeRabbit

  • Chores
    • Style checks, code formatting, and unit tests now use the existing XDEBUG_MODE environment setting instead of overriding it. When no value is set, these commands no longer force Xdebug off.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d748d73f-0220-4bc8-8a94-4d79c9ae37d9
📥 Commits

Reviewing files that changed from the base of the PR and between af59382 and 581a594.

📒 Files selected for processing (3)
  • bin/check-style
  • bin/format-style
  • bin/unit-tests

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The style-check, style-formatting, and unit-test scripts no longer set XDEBUG_MODE to off before running their PHP tools. The tools use the caller’s existing environment value.

Changes

PHP tool environment

Layer / File(s) Summary
PHP tool invocations
bin/check-style, bin/format-style, bin/unit-tests
The scripts invoke PHPCS, phpcbf, and PHPUnit without defaulting XDEBUG_MODE to off.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 581a5

The change preserves the caller’s Xdebug setting, and the checked-in CI configuration shows no conflicting mode. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the main change: removing the scripts’ default XDEBUG environment setting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the scripts today,
No Xdebug switch is forced away.
PHPCS runs with env intact,
PHPUnit follows the same exact track.
The formatter keeps its setting, too,
Then hops along with work to do.

Comment @coderabbitai help to get the list of available commands.

@tijmenbruggeman
tijmenbruggeman marked this pull request as ready for review October 6, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant