Repository navigation
Add tests for SequencesExt SelectInSubSeq and SelectLastInSubSeq - #132
Merged
Merged
Conversation
Check the TLC overrides exhaustively against pure TLA+ definitions over all sequences in BoundedSeq(1..3, 4) and all ranges from..to, including empty ones (from > to). The overrides return an index into seq whereas the TLA+ definitions return an index into SubSeq(seq, from, to), so the tests fail whenever from > 1. Related to Github issue #131 #131 [Tests] Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
The TLA+ definitions returned an index into SubSeq(seq, from, to), whereas the doc comments and the TLC overrides return an index into seq. Align the definitions with the overrides, which most users rely on. This is a breaking change for users of the plain TLA+ definitions, but no other operator in the module and no proof depends on them. Fixes Github issue #131 #131 [Bug] Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the TLC overrides exhaustively against pure TLA+ definitions over all sequences in BoundedSeq(1..3, 4) and all ranges from..to, including empty ones (from > to). The overrides return an index into seq whereas the TLA+ definitions return an index into SubSeq(seq, from, to), so the tests fail whenever from > 1.
Related to Github issue #131
#131
[Tests]