Skip to content

fix: preserve AskUserQuestion feedback across transcript reloads - #49

Merged
shaohaozhi286 merged 5 commits into
masterfrom
fix/web-ask-feedback-persistence
Sep 14, 2026
Merged

shaohaozhi286 merged 5 commits into
masterfrom
fix/web-ask-feedback-persistence

Conversation

@LIUXIN557

Copy link
Copy Markdown
Collaborator

Summary

  • consume persisted tool-call names in message order so reused call IDs cannot inherit an earlier tool name
  • add regressions for cross-turn ID reuse and future-call non-matching
  • strengthen the renderer architecture assertion to require strict sibling adjacency
  • retain persistence coverage for submit/cancel, self-heal, transcript replacement, and continuation flows

Verification

  • cd web && node src/lib/sessionTranscript.test.js
  • cd web && node src/lib/transcriptRendererArchitecture.test.js
  • cd web && node src/lib/questionFeedbackPersistence.test.js
  • cd web && pnpm test
  • git diff --cached --check

Known repository note: unrestricted Git status/diff scans are blocked by the damaged external/cpp-mcp submodule metadata; only the scoped review files were staged.

Trae User and others added 5 commits September 14, 2026 18:04
补齐缺失的反馈模块,使用共享 ToolBlock 渲染提交与取消结果。
取消路径写入持久化 metadata,保持模型输出和 TUI 拒绝文本不变。
修复中断后复用调用 ID 串名、取消反馈折叠及普通 metadata 误判。
以实际组件渲染验证历史重载、自恢复和继续对话,并增加 Web CI。

验证:前端全套测试(2323 项通过记录)、生产构建、219 项原生回归、
GCC 11 编译检查、OpenSpec 严格校验及 git diff --cached --check 通过。
@shaohaozhi286
shaohaozhi286 changed the base branch from improve/build-dry-run to master September 14, 2026 15:49
@shaohaozhi286
shaohaozhi286 merged commit e0a321b into master Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants