fix(web): make the add-on stepper's total-quantity semantics explicit - #968
Merged
Conversation
Dogfooding on staging surfaced the misread immediately: owning 1 add-on and stepping to 2, the page showed 'Update add-ons' with 'New total: $4/mo' — which reads as 'buy 2 more for another $4', when it means 'own 2 in total, +$2/mo'. On a money control that ambiguity is a defect. - The stepper gains a visible 'Total add-ons' label. - A staged change names the total on the button itself: 'Update to 2 add-ons' / 'Buy 2 add-ons'. - The preview states both the new monthly total AND the delta this click commits: 'New monthly total: $4/mo (+1 add-on, +$2/mo)' (negative deltas rendered on decreases). Tests: 2 new cases pinning the reported scenario (add one more to an owned add-on; reduce shows a negative delta); labels updated across the suite, 17/17; full web suite green; tsc + prod build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScEpytuD7GvaXEssvJ2W32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found dogfooding #960/#967 on staging: owning 1 add-on and stepping to 2 showed Update add-ons + New total: $4/mo, which reads as "buy 2 more for another $4" — the stepper is the account total, but nothing said so.
Tests: 2 new cases pinning the reported scenario; suite 17/17, full web green, tsc + prod build clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ScEpytuD7GvaXEssvJ2W32