Ship /public/dumps/public symlink in singleuser image - #532
Merged
Conversation
dhinus
previously approved these changes
Aug 20, 2026
Previously /public/dumps was a nfs mount and thus didn't need to exist in the host or container filesystem. Changing the type to DirectoryOrCreate means the path needs to exist on the worker, and it can't be created in the read-only container, thus singleuser fails to start. Switch to shipping the now-static symlink /public/dumps/public to /mnt/nfs/dumps which is where dumps-nfs.w.o is now canonically mounted.
filippog
force-pushed
the
dumps-nfs-public-symlink
branch
from
August 20, 2026 13:53
5b407a4 to
141bbe3
Compare
dhinus
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously /public/dumps was a nfs mount and thus didn't need to exist in the host or container filesystem.
Changing the type to DirectoryOrCreate means the path needs to exist on the worker, and it can't be created in the read-only container, thus singleuser fails to start.
Switch to shipping the now-static symlink /public/dumps/public to /mnt/nfs/dumps which is where dumps-nfs.w.o is now canonically mounted.