Add Forms reporting and the dev lets-talk form definition - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Reports portal can now discover forms, read submissions across published and retired revisions, filter by inclusive UTC dates, and download all matching rows as CSV. Reporting remains restricted to the existing reporting roles/scopes; the directory does not grant editing access.
lets_talkdefinition, development-only publication script, and renderer support for Kafka opt-in and hidden attribution answers.Validation:
pnpm lint,pnpm build,pnpm typecheck, 36 unit/renderer tests, and 24 integration tests against disposable PostgreSQL. Coverage includes the actual contact definition/Kafka retry path, authorization, revision unions, date boundaries, cursor rejection, and a 1,002-row CSV export.Rollout: deploy API and existing SubmissionEvent migration, configure Bus API credentials/CORS, publish the dev definition using
FORMS_ADMIN_TOKEN, then deploy the companion website and portal changes. No live deployment or form publication was performed. CSV uses an export-start timestamp bound, not a repeatable-read database snapshot. Historical HubSpot submissions are not imported.Companion PRs: Reports UI and development website.