Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forms deployments previously used a fixed CloudFormation secret list, so service/global appvars such as the Bus API authentication settings never reached the running task. This switches runtime deployment to the same pinned
tc-deploy-scriptsv1.4.20 flow used bybus-api-v6./config/forms-api-v6/deployvarwithpsvar-processor.sh, then invokemaster_deploy.sh -d ECS -t latest -j "/config/${APPNAME}/appvar,/config/common/global-appvar" -i "$APPNAME" -p FARGATEfor the selected environment.Validation:
pnpm lintandpnpm buildpass. A dry run of the actual shared scripts, using dev parameter names/settings with ECS registration mocked, verified all 20 SSM references, service precedence, CPU/memory, roles, port, health check, read-only filesystem, and log configuration. Migration success/failure checks verified that failed migrations stop the helper and that migration tasks receive only the database secret. CircleCI YAML, shell steps, Python syntax, and generated Node health-check syntax pass.The dev deployvars are provisioned, and the current CORS/runtime environment settings are preserved as service appvars. The shared dev execution role can read both SSM paths. This revision does not deploy a new runtime; the existing healthy dev service remains on task revision 9. Production requires its corresponding deployvars/appvars before deployment. CloudFormation continues to own infrastructure; normal runtime releases now update ECS directly, matching the other v6 services.