Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket
PM-6343
What's in this PR?
The Sales filter row mixed labels inside the text inputs with a label above the dropdown, leaving the controls misaligned. Search sales, Filter field and Contains now use persistent labels above matching 48px controls, with equal widths on desktop and stacked fields on mobile. Explicit label associations preserve keyboard and screen-reader access.
Validation:
yarn lint, the production dev build and all six existing Sales tests pass. Browser checks of both local and deployed dev assets, using synthetic report data, at 2048px, 1440px, 768px and 390px confirm aligned desktop labels/controls, equal control heights, visible keyboard focus, working search and disabled/enabled Contains behavior, and no page overflow or JavaScript errors.Follow-up to #2303. Dev preview: https://sales.topcoder-dev.com