fix: allow talent managers to access internal projects they belong to - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talent Managers explicitly added to an internal project were still blocked by
INTERNAL_BILLING_ACCOUNT_IDS. Active project membership now overrides that exclusion for both Talent Manager roles, across project lists and totals (including My Projects), direct project reads, and nested project routes.The override accepts any active project membership role. Deleted memberships and pending invitations alone do not grant internal-project access. The route interceptor checks current database membership even when request membership context is cached. Updated the README and configuration documentation to describe the policy.
Platform UI already permits explicit project members and consumes the API's filtered project lists, so no frontend change is required.
Validation:
pnpm lintpnpm build(after regenerating the local Prisma client)pnpm test --runInBand internal-project.utils.spec.ts projectContext.interceptor.spec.ts project.service.spec.ts project.utils.spec.ts