chore: drop a friction entry that duplicated an open issue, and shorten the other - #223
Conversation
…en the other The `--mark-seen` entry duplicated `#42`, an open issue filed during the OpenKitchen adoption describing the same behaviour. It carried no new information, cost review rounds as committed prose, drew a finding of its own for stating the wrong remedy, and would have cost a second pass when `triage-friction-log` graduated it into the issue that already existed. What it actually added — that the remedy is poll then `--mark-seen`, not a second bare `--mark-seen`, which the engine documents as an idempotent no-op — is now an occurrence comment on `#42`, where the record already was. The heredoc entry is shortened rather than corrected again. Its mechanism explanation was shell-specific and stated as general: under bash and sh, `$598` expands to `$5` followed by literal `98`, not to the empty string. That claim is gone rather than qualified, per "a claim that has needed repairing twice is doing more work than it can carry". The observation and the fix survive, and the fix never depended on the shell. The routing this restores is the friction log's own preamble: most friction is filed directly as issues, and the tracker should be searched before an entry is written at all. `#222` carries that argument with this duplication as its evidence. Verified in the repository root: `uv run scripts/check_doc_budget.py` — the friction log is still over budget and still reported; the sweep is `triage-friction-log` and needs operator approval, so it is not done here. Claude-Session: https://claude.ai/code/session_01PJUnxLwWJTfQg1qZDsm7h3
📝 WalkthroughWalkthroughThe heredoc friction-log entry was condensed. It now records the swallowed ChangesHeredoc friction documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Round 1 — terminal. One finding, found by both lenses, already corrected.
Both lenses independently verified the added sentence is true — running the heredoc in bash, sh and zsh, one confirming byte-for-byte with So the diff is more accurate than what it replaced. Only my header oversold it. What the round confirmed rather than found
The proportionality note this PR is itself evidence forRemoving ten lines of duplicate prose cost a full panel, because it is committed. The same content filed as an occurrence comment on |
Removes a friction-log entry that duplicated an open issue, and shortens the
other. Deletions and one shortening.
An earlier version of this line said "no new factual claim is introduced." A
review lens caught that as inaccurate: the shortened entry adds one sentence —
"Exactly what gets swallowed is shell-dependent; the fix does not depend on
which." It is true (verified in bash, sh and zsh, below) and it replaces a false
universal claim with a correct hedge — but it is a new assertion, and the header
said there were none.
Why
The
--mark-seenentry duplicated #42, an open issue filed during theOpenKitchen adoption describing the same behaviour: posting the review record
un-converges the PR.
That entry carried no new information, cost review rounds as committed prose,
drew a finding of its own for stating the wrong remedy, and would have cost a
second pass later when
triage-friction-loggraduated it into the issue thatalready existed.
What it genuinely added — the remedy is poll, then
--mark-seen, not a secondbare
--mark-seen, whichpr_watch.pydocuments as an idempotent no-op — is nowan occurrence comment on #42, where the record already was. Zero review cost,
lands beside the original.
The heredoc entry is shortened, not corrected again
Its mechanism explanation was shell-specific and stated as general. Under bash and
sh,
$598expands to$5(empty) followed by literal98— "against 98 atthe base", not the empty string:
A round-3 lens found this and it was logged rather than fixed under the bound
declared on #221. Since the file was being edited anyway, the claim is deleted
rather than qualified — "a claim that has needed repairing twice is doing more
work than it can carry". The observation and the proposed fix survive, and the fix
never depended on which shell ran.
What this restores
The friction log's own preamble already prescribes this routing:
#222 carries that argument in full, with this duplication as its evidence, and
proposes that a tracker search precede writing a friction entry at all.
Budget
uv run scripts/check_doc_budget.py, run in the repository root — the friction logis still over budget and still reported. This claws back some lines; it is not
a sweep. Graduating the inbox needs tracker writes and operator approval, so
triage-friction-logremains the mechanism and is deliberately not run here.Review
Documentation only. Blast-radius class: second. Prose class: record — the
delta is deletions and one shortened claim; nothing here is executed by an agent
or an operator, and the
▶ Next:line is untouched.Stating that draw explicitly because the last delta-pass draw on #221 was
disputed and refused, correctly. This PR claims no delta pass — it is offered
for a full panel.