Make tests pass on small terminal width - #338
Open
socksy wants to merge 1 commit into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
📝 WalkthroughWalkthroughHelp-output tests now disable terminal line wrapping when rendering catalog and root command help, keeping beta-label assertions consistent across short, long, and subcommand help. ChangesCLI help assertions
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
socksy
force-pushed
the
fix/help-test-terminal-width
branch
from
July 30, 2026 15:45
1ec1e84 to
ffb3b8c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
socksy
force-pushed
the
fix/help-test-terminal-width
branch
from
July 30, 2026 15:46
ffb3b8c to
b8bd3dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when I ran
cargo testlocally it failed... because my terminal window was smaller than the help text we were asserting against, so the line breaks were misplaced. This makes that test a bit more resilient against that by flattening the text before asserting.Summary by CodeRabbit