Conversation
Emacs 31.1 marked `if-let', `when-let' and `and-let' obsolete in favour
of the starred variants. Because julia-repl.el sets `no-byte-compile:
t', it is macroexpanded at load time, so every Emacs 31 user sees these
warnings whenever julia-repl is loaded:
julia-repl.el: Warning: ‘if-let’ is an obsolete macro (as of 31.1); use ‘if-let*’ instead. [5 times]
julia-repl.el: Warning: ‘when-let’ is an obsolete macro (as of 31.1); use ‘when-let*’ or ‘and-let*’ instead.
All six call sites bind a single variable, so the rewrite is
semantics-preserving. `if-let*' and `when-let*' have existed since
Emacs 26.1, well below the package's 29.1 requirement.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ETZ3Po9TDsuH7aNhtvkZcb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emacs 31.1 marked
if-let,when-letandand-letobsolete in favour of the starred variants.Because
julia-repl.elsetsno-byte-compile: t, the file is macroexpanded at load time, so on Emacs 31 these warnings appear for every user whenever julia-repl is loaded — not just when someone byte-compiles it:All six call sites bind a single variable, so
if-let*/when-let*are exactly equivalent here. Both macros have existed since Emacs 26.1, well below the package's 29.1 requirement, so this needs no change toPackage-Requires.Tested with the repo's ert suite on Emacs 31.1 (4/4 passing), and the warnings are gone on load.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ETZ3Po9TDsuH7aNhtvkZcb